Improve the whole messages.h situation

This commit splits the old messages.h file into two, one private
(messages.h) and one public (pdb_msg.h).  This new arrangement keeps the
old model of one message pool for all the PD Buddy firmware library, but
moves the macro for the number of objects it contains into a new file,
pdb_conf.h, placed at the project root.  The pool itself is kept in the
new pdb_msg.h file, since the DPM may need to access it.

The new configuration file also contains the stack sizes for the PD
Buddy threads (some will be moved back to secrecy in the future once the
needed sizes are known, but the PE's stack size should be kept in
pdb_conf.h since user code needs that stack).

lib/include/fusb302b.h

@@ -23,7 +23,7 @@
 
 #include <pdb_fusb.h>
 
-#include "messages.h"
+#include <pdb_msg.h>
 
 
 /* I2C addresses of the FUSB302B chips */

lib/include/pdb.h

@@ -24,6 +24,7 @@
 #include <pdb_pe.h>
 #include <pdb_prl.h>
 #include <pdb_int_n.h>
+#include <pdb_msg.h>
 
 
 /*

lib/include/pdb_dpm.h

@@ -21,9 +21,9 @@
 
 #include <stdbool.h>
 
-/* TODO: improve these includes */
+#include <pdb_msg.h>
+/* TODO: improve this include */
 #include "fusb302b.h"
-#include "messages.h"
 
 
 /* Forward declaration of struct pdb_config */

lib/include/pdb_int_n.h

@@ -21,9 +21,11 @@
 
 #include <ch.h>
 
+#include "pdb_conf.h"
+
 
 struct pdb_int_n {
-    THD_WORKING_AREA(_wa, 128);
+    THD_WORKING_AREA(_wa, PDB_INT_N_WA_SIZE);
     thread_t *thread;
 };
 

lib/include/messages.h → lib/include/pdb_msg.h

@@ -16,8 +16,8 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-#ifndef PDB_MESSAGES_H
-#define PDB_MESSAGES_H
+#ifndef PDB_MSG_H
+#define PDB_MSG_H
 
 #include <stdint.h>
 
@@ -46,15 +46,10 @@ union pd_msg {
     } __attribute__((packed));
 };
 
-/* Available messages */
-#define PDB_MSG_POOL_SIZE 4
-
-extern memory_pool_t pdb_msg_pool;
-
 /*
- * Initialize the msg_pool
+ * The pool of messages used by the library
  */
-void pdb_msg_pool_init(void);
+extern memory_pool_t pdb_msg_pool;
 
 
-#endif /* PDB_MESSAGES_H */
+#endif /* PDB_MSG_H */

lib/include/pdb_pe.h

@@ -24,6 +24,8 @@
 
 #include <ch.h>
 
+#include "pdb_conf.h"
+
 /*
  * Events for the Policy Engine thread, sent by user code
  */
@@ -37,7 +39,7 @@
  * Structure for Policy Engine thread and variables
  */
 struct pdb_pe {
-    THD_WORKING_AREA(_wa, 256);
+    THD_WORKING_AREA(_wa, PDB_PE_WA_SIZE);
     thread_t *thread;
 
     /* PE mailbox for received PD messages */

lib/include/pdb_prl.h

@@ -23,13 +23,15 @@
 
 #include <ch.h>
 
+#include "pdb_conf.h"
+
 
 struct pdb_prl {
-    THD_WORKING_AREA(_rx_wa, 256);
+    THD_WORKING_AREA(_rx_wa, PDB_PRLRX_WA_SIZE);
     thread_t *rx_thread;
-    THD_WORKING_AREA(_tx_wa, 256);
+    THD_WORKING_AREA(_tx_wa, PDB_PRLTX_WA_SIZE);
     thread_t *tx_thread;
-    THD_WORKING_AREA(_hardrst_wa, 256);
+    THD_WORKING_AREA(_hardrst_wa, PDB_HARDRST_WA_SIZE);
     thread_t *hardrst_thread;
 
     mailbox_t tx_mailbox;

lib/src/messages.c

@@ -18,6 +18,10 @@
 
 #include "messages.h"
 
+#include <pdb_msg.h>
+
+#include "pdb_conf.h"
+
 
 /* The messages that will be available for threads to pass each other */
 static union pd_msg pd_messages[PDB_MSG_POOL_SIZE] __attribute__((aligned(sizeof(stkalign_t))));

lib/src/messages.h

@@ -0,0 +1,29 @@
+/*
+ * PD Buddy - USB Power Delivery for everyone
+ * Copyright (C) 2017 Clayton G. Hobbs <clay@lakeserv.net>
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef PDB_MESSAGES_H
+#define PDB_MESSAGES_H
+
+
+/*
+ * Initialize the pdb_msg_pool
+ */
+void pdb_msg_pool_init(void);
+
+
+#endif /* PDB_MESSAGES_H */

lib/src/pdb.c

@@ -29,7 +29,7 @@
 void pdb_init(struct pdb_config *cfg)
 {
     /* Initialize the empty message pool */
-    pdb_msg_pool_init(/*TODO cfg*/);
+    pdb_msg_pool_init();
 
     /* Initialize the FUSB302B */
     fusb_setup(&cfg->fusb);

lib/src/policy_engine.c

@@ -20,7 +20,6 @@
 
 #include <stdbool.h>
 
-#include "messages.h"
 #include "priorities.h"
 #include "protocol_tx.h"
 #include "hard_reset.h"

lib/src/protocol_rx.c

@@ -24,7 +24,6 @@
 #include "policy_engine.h"
 #include "protocol_tx.h"
 #include "fusb302b.h"
-#include "messages.h"
 #include "pd.h"
 
 

lib/src/protocol_tx.c

@@ -22,7 +22,6 @@
 #include "policy_engine.h"
 #include "protocol_rx.h"
 #include "fusb302b.h"
-#include "messages.h"
 #include "pd.h"
 
 

lib/templates/pdb_conf.h

@@ -0,0 +1,42 @@
+/*
+ * PD Buddy - USB Power Delivery for everyone
+ * Copyright (C) 2017 Clayton G. Hobbs <clay@lakeserv.net>
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef PDB_CONF_H
+#define PDB_CONF_H
+
+
+/* Number of messages in the message pool */
+#define PDB_MSG_POOL_SIZE 4
+
+/* Size of the Policy Engine thread's working area */
+#define PDB_PE_WA_SIZE 256
+
+/* Size of the protocol layer RX thread's working area */
+#define PDB_PRLRX_WA_SIZE 256
+
+/* Size of the protocol layer TX thread's working area */
+#define PDB_PRLTX_WA_SIZE 256
+
+/* Size of the protocol layer hard reset thread's working area */
+#define PDB_HARDRST_WA_SIZE 256
+
+/* Size of the INT_N thread's working area */
+#define PDB_INT_N_WA_SIZE 128
+
+
+#endif /* PDB_CONF_H */

pdb_conf.h

@@ -0,0 +1,42 @@
+/*
+ * PD Buddy - USB Power Delivery for everyone
+ * Copyright (C) 2017 Clayton G. Hobbs <clay@lakeserv.net>
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#ifndef PDB_CONF_H
+#define PDB_CONF_H
+
+
+/* Number of messages in the message pool */
+#define PDB_MSG_POOL_SIZE 4
+
+/* Size of the Policy Engine thread's working area */
+#define PDB_PE_WA_SIZE 256
+
+/* Size of the protocol layer RX thread's working area */
+#define PDB_PRLRX_WA_SIZE 256
+
+/* Size of the protocol layer TX thread's working area */
+#define PDB_PRLTX_WA_SIZE 256
+
+/* Size of the protocol layer hard reset thread's working area */
+#define PDB_HARDRST_WA_SIZE 256
+
+/* Size of the INT_N thread's working area */
+#define PDB_INT_N_WA_SIZE 128
+
+
+#endif /* PDB_CONF_H */

src/device_policy_manager.h

@@ -23,7 +23,6 @@
 
 #include <pdb.h>
 #include "fusb302b.h"
-#include "messages.h"
 
 
 struct pdbs_dpm_data {