Use semantic LED event names

src/device_policy_manager.c

@@ -48,7 +48,7 @@ bool pdb_dpm_evaluate_capability(const union pd_msg *capabilities, union pd_msg
     uint8_t numobj = PD_NUMOBJ_GET(capabilities);
 
     /* Make the LED blink to indicate ongoing power negotiations */
-    chEvtSignal(pdb_led_thread, PDB_EVT_LED_FAST_BLINK);
+    chEvtSignal(pdb_led_thread, PDB_EVT_LED_NEGOTIATING);
 
     /* Get whether or not the power supply is constrained */
     dpm_unconstrained_power = capabilities->obj[0] & PD_PDO_SRC_FIXED_UNCONSTRAINED;
@@ -189,7 +189,7 @@ bool pdb_dpm_evaluate_typec_current(void)
 
 void pdb_dpm_pd_start(void)
 {
-    chEvtSignal(pdb_led_thread, PDB_EVT_LED_FAST_BLINK);
+    chEvtSignal(pdb_led_thread, PDB_EVT_LED_NEGOTIATING);
 }
 
 void pdb_dpm_sink_standby(void)
@@ -211,11 +211,11 @@ void pdb_dpm_output_set(bool state)
     /* Set the power output */
     if (state) {
         /* Turn the output on */
-        chEvtSignal(pdb_led_thread, PDB_EVT_LED_MEDIUM_BLINK_OFF);
+        chEvtSignal(pdb_led_thread, PDB_EVT_LED_OUTPUT_ON);
         palSetLine(LINE_OUT_CTRL);
     } else {
         /* Turn the output off */
-        chEvtSignal(pdb_led_thread, PDB_EVT_LED_ON);
+        chEvtSignal(pdb_led_thread, PDB_EVT_LED_OUTPUT_OFF);
         palClearLine(LINE_OUT_CTRL);
     }
 }

src/led.h

@@ -30,6 +30,13 @@
 #define PDB_EVT_LED_SLOW_BLINK EVENT_MASK(4)
 #define PDB_EVT_LED_FAST_BLINK_SLOW EVENT_MASK(5)
 
+/* Semantic LED event names */
+#define PDB_EVT_LED_CONFIG PDB_EVT_LED_SLOW_BLINK
+#define PDB_EVT_LED_IDENTIFY PDB_EVT_LED_FAST_BLINK_SLOW
+#define PDB_EVT_LED_NEGOTIATING PDB_EVT_LED_FAST_BLINK
+#define PDB_EVT_LED_OUTPUT_ON PDB_EVT_LED_MEDIUM_BLINK_OFF
+#define PDB_EVT_LED_OUTPUT_OFF PDB_EVT_LED_ON
+
 /* The LED thread object */
 extern thread_t *pdb_led_thread;
 

src/main.c

@@ -67,7 +67,7 @@ static const I2CConfig i2c2config = {
 static void setup(void)
 {
     /* Indicate that we're in setup mode */
-    chEvtSignal(pdb_led_thread, PDB_EVT_LED_SLOW_BLINK);
+    chEvtSignal(pdb_led_thread, PDB_EVT_LED_CONFIG);
 
     /* Disconnect from USB */
     usbDisconnectBus(serusbcfg.usbp);

src/shell.c

@@ -224,7 +224,7 @@ static void cmd_identify(BaseSequentialStream *chp, int argc, char *argv[])
         return;
     }
 
-    chEvtSignal(pdb_led_thread, PDB_EVT_LED_FAST_BLINK_SLOW);
+    chEvtSignal(pdb_led_thread, PDB_EVT_LED_IDENTIFY);
 }
 
 static const struct pdb_shell_cmd commands[] = {