Added tests for a few untested lines

test_pdbuddy/__init__.py

@@ -20,12 +20,20 @@ class SinkTestCase(unittest.TestCase):
                 flags=pdbuddy.SinkFlags.NONE, v=15000, i=3000)
         self.obj_valid_gb = pdbuddy.SinkConfig(status=pdbuddy.SinkStatus.VALID,
                 flags=pdbuddy.SinkFlags.GIVEBACK, v=15000, i=3000)
-        self.obj_huge_vi = pdbuddy.SinkConfig(status=pdbuddy.SinkStatus.VALID,
-                flags=pdbuddy.SinkFlags.NONE, v=65536, i=65536)
-        self.obj_big_vi = pdbuddy.SinkConfig(status=pdbuddy.SinkStatus.VALID,
-                flags=pdbuddy.SinkFlags.NONE, v=20001, i=5001)
-        self.obj_neg_vi = pdbuddy.SinkConfig(status=pdbuddy.SinkStatus.VALID,
-                flags=pdbuddy.SinkFlags.NONE, v=-1, i=-1)
+
+        self.obj_huge_v = pdbuddy.SinkConfig(status=pdbuddy.SinkStatus.VALID,
+                flags=pdbuddy.SinkFlags.NONE, v=65536, i=1000)
+        self.obj_big_v = pdbuddy.SinkConfig(status=pdbuddy.SinkStatus.VALID,
+                flags=pdbuddy.SinkFlags.NONE, v=20001, i=1000)
+        self.obj_neg_v = pdbuddy.SinkConfig(status=pdbuddy.SinkStatus.VALID,
+                flags=pdbuddy.SinkFlags.NONE, v=-1, i=1000)
+
+        self.obj_huge_i = pdbuddy.SinkConfig(status=pdbuddy.SinkStatus.VALID,
+                flags=pdbuddy.SinkFlags.NONE, v=5000, i=65536)
+        self.obj_big_i = pdbuddy.SinkConfig(status=pdbuddy.SinkStatus.VALID,
+                flags=pdbuddy.SinkFlags.NONE, v=5000, i=5001)
+        self.obj_neg_i = pdbuddy.SinkConfig(status=pdbuddy.SinkStatus.VALID,
+                flags=pdbuddy.SinkFlags.NONE, v=5000, i=-1)
 
     def tearDown(self):
         # Close the connection to the PD Buddy Sink
@@ -52,17 +60,29 @@ class SinkTestCase(unittest.TestCase):
         self.pdbs.set_tmpcfg(self.obj_valid_gb)
         self.assertEqual(self.pdbs.get_tmpcfg(), self.obj_valid_gb)
 
-    def test_set_tmpcfg_huge_vi(self):
+    def test_set_tmpcfg_huge_v(self):
+        with self.assertRaises(ValueError):
+            self.pdbs.set_tmpcfg(self.obj_huge_v)
+
+    def test_set_tmpcfg_big_v(self):
+        with self.assertRaises(ValueError):
+            self.pdbs.set_tmpcfg(self.obj_big_v)
+
+    def test_set_tmpcfg_neg_v(self):
+        with self.assertRaises(ValueError):
+            self.pdbs.set_tmpcfg(self.obj_neg_v)
+
+    def test_set_tmpcfg_huge_i(self):
         with self.assertRaises(ValueError):
-            self.pdbs.set_tmpcfg(self.obj_huge_vi)
+            self.pdbs.set_tmpcfg(self.obj_huge_i)
 
-    def test_set_tmpcfg_big_vi(self):
+    def test_set_tmpcfg_big_i(self):
         with self.assertRaises(ValueError):
-            self.pdbs.set_tmpcfg(self.obj_big_vi)
+            self.pdbs.set_tmpcfg(self.obj_big_i)
 
-    def test_set_tmpcfg_neg_vi(self):
+    def test_set_tmpcfg_neg_i(self):
         with self.assertRaises(ValueError):
-            self.pdbs.set_tmpcfg(self.obj_neg_vi)
+            self.pdbs.set_tmpcfg(self.obj_neg_i)
 
     def test_write(self):
         self.test_set_tmpcfg_valid()
@@ -113,6 +133,10 @@ class SinkTestCase(unittest.TestCase):
         except ValueError:
             self.skipTest("Unknown value returned by PD Buddy Sink")
 
+    def test_send_command_invalid(self):
+        with self.assertRaises(KeyError):
+            self.pdbs.send_command("foo bar")
+
 
 class SinkConfigTestCase(unittest.TestCase):