More formatting, improve NEC organization

Now the NEC reading code doesn't leak excessive information to the rest
of the firmware, keeping its internal state in static variables at
function scope.

src/main.c

@@ -95,18 +95,26 @@ static const GPTConfig gpt4cfg = {
     0, 0
 };
 
-/*===========================================================================*/
-/* ICU related code.                                                         */
-/*===========================================================================*/
-static int32_t index = -1;
-static bool START_OCCURED = FALSE, REPEAT_FLAG = FALSE;
-static uint32_t tmp, command;
-
-static void icuwidthcb(ICUDriver *icup) {
+
+/*
+ * Variables for holding the most recently read information from icuwidthcb
+ */
+static uint8_t nec_addr, nec_data;
+static bool nec_repeat = false;
+
+/*
+ * ICU pulse width callback for reading NEC remote control frames
+ */
+static void icuwidthcb(ICUDriver *icup)
+{
+    static int32_t index = -1;
+    static bool START_OCCURED = false;
+    static uint32_t tmp;
+
     icucnt_t cnt = icuGetWidthX(icup);
     if ((cnt > (START_PULSE - DELTA)) && (cnt < (START_PULSE + DELTA))) {
         index = 0;
-        START_OCCURED = TRUE;
+        START_OCCURED = true;
     } else if ((cnt > (ONE_PULSE - DELTA)) && (cnt < (ONE_PULSE + DELTA))) {
         tmp |= 1 << (31 - index);
         index++;
@@ -115,15 +123,17 @@ static void icuwidthcb(ICUDriver *icup) {
         index++;
     } else if ((cnt > (END_PULSE - 4*DELTA)) && (cnt < (END_PULSE + 4*DELTA))) {
         if ((START_OCCURED) && (index == 32)) {
-            command = tmp;
+            nec_addr = (tmp >> 24) & 0xFF;
+            nec_data = (tmp >> 8) & 0xFF;
         } else {
-            command = 0;
+            nec_addr = 0;
+            nec_data = 0;
         }
-        REPEAT_FLAG = FALSE;
-        START_OCCURED = FALSE;
+        nec_repeat = false;
+        START_OCCURED = false;
         index = -1;
     } else if ((cnt > (RPT_CMD_PULSE - DELTA)) && (cnt < (RPT_CMD_PULSE + DELTA))) {
-        REPEAT_FLAG = TRUE;
+        nec_repeat = true;
     } else if ((cnt > (COMMA_PULSE - DELTA)) && (cnt < (COMMA_PULSE + DELTA))) {
         chEvtBroadcastFlags(&IR_receiver, 0);
     } else {
@@ -131,6 +141,7 @@ static void icuwidthcb(ICUDriver *icup) {
     }
 }
 
+/* Configuration for the ICU */
 static ICUConfig icucfg = {
     ICU_INPUT_ACTIVE_HIGH,
     10000,            /* 10kHz ICU clock frequency. */
@@ -141,6 +152,7 @@ static ICUConfig icucfg = {
     0
 };
 
+
 /*
  * Synchronously send one bit for RC5
  */
@@ -179,11 +191,12 @@ void rc5_frame(bool toggle, int addr, int data)
     }
 }
 
+
 /*
  * Application entry point.
  */
-int main(void) {
-
+int main(void)
+{
     /*
      * System initializations.
      * - HAL initialization, this also initializes the configured device drivers
@@ -216,7 +229,7 @@ int main(void) {
 
     /* Send a continuous stream of power off signals to the TV */
     while (true) {
-        if (command == 0x807F18E7) {
+        if (nec_addr == 0x80 && nec_data == 0x18) {
             if (chEvtWaitAnyTimeout(ALL_EVENTS, MS2ST(200))) {
                 continue;
             }